Skip to content

Ruby: enable overlay compilation #19731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Ruby: enable overlay compilation #19731

merged 1 commit into from
Jul 14, 2025

Conversation

@nickrolfe
Copy link
Contributor

@nickrolfe nickrolfe commented Jun 11, 2025 •
edited
Loading

Stacked on top of #19989

@github-actions github-actions bot added the Ruby label Jun 11, 2025
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-discard-predicates branch from 4875dcb to 3d78f35 Compare June 17, 2025 08:47
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-compile-for-overlay-eval branch 2 times, most recently from 04c2743 to f29f327 Compare June 17, 2025 10:11
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-discard-predicates branch 2 times, most recently from c9e7be7 to c968a95 Compare June 19, 2025 15:36
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-compile-for-overlay-eval branch from f29f327 to b96dc5a Compare June 19, 2025 15:37
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-discard-predicates branch from e36a625 to a9ddf00 Compare June 25, 2025 10:48
Base automatically changed from nickrolfe/ruby-discard-predicates to main June 25, 2025 11:18
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-compile-for-overlay-eval branch from b96dc5a to 6fcb669 Compare July 7, 2025 11:27
@nickrolfe nickrolfe changed the base branch from main to nickrolfe/ruby-annotations July 7, 2025 11:27
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-annotations branch from 2c0ac5e to 770dd30 Compare July 7, 2025 13:57
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-compile-for-overlay-eval branch from 6fcb669 to 14b6c47 Compare July 7, 2025 13:58
@github-actions github-actions bot removed the QL-for-QL label Jul 7, 2025
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-annotations branch from 770dd30 to 4a725ba Compare July 7, 2025 14:32
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-compile-for-overlay-eval branch from 14b6c47 to b4ab74b Compare July 7, 2025 14:33
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-annotations branch from 4a725ba to 3c4a528 Compare July 7, 2025 14:57
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-compile-for-overlay-eval branch from b4ab74b to 55f9231 Compare July 7, 2025 14:57
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-annotations branch 3 times, most recently from 1eda55d to e1f2433 Compare July 9, 2025 10:59
@nickrolfe nickrolfe force-pushed the nickrolfe/ruby-compile-for-overlay-eval branch from 55f9231 to ab9ba02 Compare July 10, 2025 09:38
Base automatically changed from nickrolfe/ruby-annotations to main July 10, 2025 15:53
@nickrolfe nickrolfe marked this pull request as ready for review July 10, 2025 16:09
Copilot AI review requested due to automatic review settings July 10, 2025 16:09
@nickrolfe nickrolfe requested a review from a team as a code owner July 10, 2025 16:09
Copilot AI reviewed Jul 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables overlay compilation for the Ruby CodeQL library by adding the compileForOverlayEval: true configuration option to the qlpack.yml file. This change allows the Ruby library to be compiled in a way that supports overlay evaluation, which is typically used for performance optimization or dynamic analysis scenarios.

  • Adds overlay compilation capability to the Ruby CodeQL library

@nickrolfe nickrolfe added the no-change-note-required This PR does not need a change note label Jul 11, 2025
kaspersv
kaspersv approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@kaspersv kaspersv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the Foundations team, I believe we are ready to enable overlay compilation. In theory, this should not affect the semantics for non-overlay evaluation but may affect performance of non-overlay evaluation. DCA shows no alert differences (though DCA skips rb/polynomial-redos for jeremyevans__sequel for both base and variant due to the number of results) and a slight speedup.

DIL size increases significantly for several queries. I sampled a few queries and didn't see anything concerning.

@nickrolfe nickrolfe merged commit c941e91 into main Jul 14, 2025
10 of 11 checks passed
@nickrolfe nickrolfe deleted the nickrolfe/ruby-compile-for-overlay-eval branch July 14, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kaspersv kaspersv kaspersv approved these changes

Assignees

@kaspersv kaspersv

Labels

no-change-note-required This PR does not need a change note Ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickrolfe @kaspersv